Skip to content

feat(Storage): adding retry configuration example. #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(Storage): adding retry configuration example. #2149

wants to merge 2 commits into from

Conversation

piotrgradzinski
Copy link

Example on how to pass configuration related to retries to StorageClient and operations that include:

  • retries
  • retry strategy
  • delay function
  • calc delay function
  • retry function

Fixes googleapis/google-cloud-php#8309.

@piotrgradzinski piotrgradzinski requested review from a team as code owners August 3, 2025 23:20
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Aug 3, 2025 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Aug 3, 2025
bshaffer
bshaffer reviewed Aug 4, 2025
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! nice work! One small suggestion (and fixing the sample tag) and we can merge this!

Are these options dependent on googleapis/google-cloud-php#8489? If so, we can't merge this until that PR is merged and released, and we'll want to update storage/composer.json with the new minimum version

@piotrgradzinski
Copy link
Author

Are these options dependent on googleapis/google-cloud-php#8489? If so, we can't merge this until that PR is merged and released, and we'll want to update storage/composer.json with the new minimum version

Yes, they are as I added some fixes and new params in aforementioned PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs for "Retry Stategy" PHP are not accurate
2 participants
@piotrgradzinski @bshaffer